Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Add a copy button to the monitoring center #2060

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

irenhongyan
Copy link

@irenhongyan irenhongyan commented Jun 2, 2024

What's changed?

Add a copy button to the monitoring center,And realize internationalization。issus is #1727

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

@github-actions github-actions bot added the webapp label Jun 2, 2024
@irenhongyan irenhongyan changed the title Add a copy button to the monitoring center [feature] Add a copy button to the monitoring center Jun 2, 2024
@irenhongyan irenhongyan changed the base branch from master to dev June 2, 2024 09:00
@irenhongyan irenhongyan changed the base branch from dev to master June 2, 2024 09:01
@tomsun28 tomsun28 added this to the 1.6.1 milestone Jun 2, 2024
@tomsun28
Copy link
Contributor

tomsun28 commented Jun 2, 2024

hi 👍 lgtm. Recommended that merge this after releasing version 1.6.0.

@tomsun28
Copy link
Contributor

hi, i have a test for this, it seem not copy the monitor params when click copy button.

before:

image

copy:

image

@irenhongyan
Copy link
Author

irenhongyan commented Jun 16, 2024 via email

@tomsun28
Copy link
Contributor

I will make the necessary changes as soon as possible.

👍 thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

2 participants